Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.1.0 dev #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

V1.1.0 dev #41

wants to merge 3 commits into from

Conversation

jwildfire
Copy link
Contributor

Just using the newest version of web-codebook.

@jwildfire
Copy link
Contributor Author

@nandriychuk @bzkrouse Thinking you can do a quick joint review?

@jwildfire
Copy link
Contributor Author

@nandriychuk Lets also add a pkgdown site #42

nandriychuk
nandriychuk approved these changes Feb 24, 2020
View reviewed changes
Copy link

@nandriychuk nandriychuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected. The only thing, building a package gave the error listed below which doesn't seem to be connected to the web-codebook version change.

checking examples ... ERROR
Running examples in 'datadigest-Ex.R' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandriychuk nandriychuk nandriychuk approved these changes

@bzkrouse bzkrouse Awaiting requested review from bzkrouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwildfire @nandriychuk