-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example refactor #88
Example refactor #88
Conversation
Ready for a quick technical review and QC from @samussiah and then some basic regression testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new examples view looks better. I fixed the filters on the examples page and threw some styling tweaks in for good measure. We really need to go through and fix any broken examples. It'd also be nice to add a nav to the prototypes to quickly flip through them.
Refactors the appearance and metadata tracking for examples. Documentation in the updated wiki
Closes #81 #82 #83 #84 #86 #87
Test Notes
Needs a quick technical review and QC from @samussiah and then some basic regression testing.
Basically, we just need a tester to flip through the example pages and make sure they render in major browsers and that the information when clicking on the info icon for each example is accurate.