Example refactor #88
Merged
Example refactor #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for a quick technical review and QC from @samussiah and then some basic regression testing. |
samussiah
approved these changes
Mar 15, 2018
There was a problem hiding this comment.
The new examples view looks better. I fixed the filters on the examples page and threw some styling tweaks in for good measure. We really need to go through and fix any broken examples. It'd also be nice to add a nav to the prototypes to quickly flip through them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the appearance and metadata tracking for examples. Documentation in the updated wiki
Closes #81 #82 #83 #84 #86 #87
Test Notes
Needs a quick technical review and QC from @samussiah and then some basic regression testing.
Basically, we just need a tester to flip through the example pages and make sure they render in major browsers and that the information when clicking on the info icon for each example is accurate.