-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show/Hide charts & And updates to variable header #38
Conversation
.append("li") | ||
.text(d=>d.key+" ("+d3.format("0.1%")(d.prop_n)+")") | ||
.attr("title",d=>"n="+d.n) | ||
.style("cursor", "pointer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
.append("li") | ||
.text(d => d) | ||
.attr("title", d => d=="..."? nValues-6+" other values" :"") | ||
.style("cursor", d=> d=="..."?"pointer":null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - nothing happens on click, but info comes up on hover - cursor:help would probably be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #40 for this
Only confusion is with the text summary cursor pointer. What's supposed to happen on click? |
Fixes #26, #27 and #31.
Ready to Code review (@samussiah) and feature testing (@brittsikora).