Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reflectElemUntil #2

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Aug 14, 2023

Simplify the implementation of utility function reflectElemUntil.

@Rican7 Rican7 self-assigned this Aug 14, 2023
@Rican7 Rican7 added the enhancement New feature or request label Aug 14, 2023
@Rican7
Copy link
Owner

Rican7 commented Aug 14, 2023

Oh, yea, this is much simpler. No more recursion, but still very clear (I've been kinda obsessed with recursion lately lol.... whoops), and the check being compound means that it can early terminate and do less work.

Nice! Thanks!

@Rican7 Rican7 merged commit 5f2faab into Rican7:main Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants