Annual update trying to make sure Omnifit still works #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the ancient builds
dhomeier
suggested changes
Dec 18, 2021
There was a problem hiding this comment.
Thanks for your efforts in keeping the package up to date!
I put in two code suggestions that let the tests pass on my machine (only tested with Astropy 5.0 though). There does not seem to be any use of six; not sure about the matplotlib backend settings mentioned in #38.
And the CI setup may require some non-minor work as Travis is probably no longer available!
4 tasks
dhomeier
reviewed
Dec 18, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll see if I can actually improve things. Might be too lazy.