Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export default not correctly transformed when not followed by whitespace #22

Closed
Conduitry opened this issue Jun 24, 2019 · 1 comment · Fixed by #23
Closed

export default not correctly transformed when not followed by whitespace #22

Conduitry opened this issue Jun 24, 2019 · 1 comment · Fixed by #23

Comments

@Conduitry
Copy link
Collaborator

Something like

export default[42]

is getting transformed in https://shimport-demos.surge.sh/transform/ to

__shimport__.define('demo.js', [], function(__import, __exports){ default[42]
});
//# sourceURL=demo.js

This is a contrived example, but export default( will appear in minified code that is exporting the result of an IIFE.
@Conduitry
Copy link
Collaborator Author

I'm guessing this needs adjusting but I have not tried anything yet.

@Conduitry Conduitry mentioned this issue Jun 24, 2019
Merged
Rich-Harris added a commit that referenced this issue Jun 24, 2019
@Rich-Harris
Merge pull request #23 from Conduitry/gh-22
26bc438 
correctly transform `export default` followed by non-whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correctly transform export default followed by non-whitespace
1 participant
@Conduitry