Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup build #43

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Cleanup build #43

merged 1 commit into from
Mar 11, 2023

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Mar 11, 2023

  • Remove /vendor dir.
  • Update minimum Go version to 1.19.
  • Fix Go module path for RichiH.
  • Fix up deprecated io/ioutil.
  • Update golangci-lint.

@SuperQ
Cleanup build
3976865 
* Remove /vendor dir.
* Update minimum Go version to 1.19.
* Fix Go module path for RichiH.
* Fix up deprecated io/ioutil.
* Update golangci-lint.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Mar 11, 2023
Merged
RichiH
RichiH approved these changes Mar 11, 2023
View reviewed changes
Copy link
Owner

@RichiH RichiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RichiH RichiH merged commit 52a360c into RichiH:main Mar 11, 2023
@DaAwesomeP
Copy link
Contributor

Amazing! Thank you!

DaAwesomeP added a commit to DaAwesomeP/modbus_exporter that referenced this pull request Mar 11, 2023
@DaAwesomeP
implement exporter-toolkit and promlog (post RichiH#43)
7cfef7b
@SuperQ SuperQ deleted the cleanup_vendor branch March 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichiH RichiH RichiH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperQ @DaAwesomeP @RichiH