Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: make navigation group label translatable via __() #35

Closed
eelco2k opened this issue Jan 3, 2024 · 1 comment
Closed

[Bug]: make navigation group label translatable via __() #35

eelco2k opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@eelco2k
Copy link

eelco2k commented Jan 3, 2024

What happened?

cannot use other language menu.

How to reproduce the bug

just install latest version with multiple localisation

Package Version

v1.0.11

PHP Version

8.2.12

Laravel Version

10.39.0

Which operating systems does with happen with?

macOS

Notes

public static function getNavigationGroup(): ?string
    {
        return __(Config::get('filament-email.resource.group' ?? parent::getNavigationGroup()));
    }
@eelco2k eelco2k added the bug Something isn't working label Jan 3, 2024
marcogermani87 pushed a commit to marcogermani87/filament-email that referenced this issue Apr 17, 2024
Fixed issue RickDBCN#35. Added access control feature into config.
5896ce7
@marcogermani87 marcogermani87 mentioned this issue Apr 17, 2024
Merged
@RickDBCN
Copy link
Owner

Fixed in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eelco2k @RickDBCN