Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Translate #27

Closed
wants to merge 4 commits into from
Closed

Conversation

mstfkhazaal
Copy link
Contributor

This is a PR repair #24
How can we test it and make sure it works correctly?

Copy link

what-the-diff bot commented Nov 2, 2023

PR Summary 🚀

  • New "Get Navigation Label" Function
    We've added a shiny new function in EmailResource.php that fetches the label directly from the system's config file 😎. And here's the kicker... If there's no label set there, don't worry – it got it covered! The function will just return a standard "Email log" label. Perfect fallback plan! 🌈

  • New "Get Navigation Group" Function
    Hold onto your hats because we've also whipped up another function in EmailResource.php named "Get Navigation Group" 😉. This hard worker fetches the group from the same config file. And in case no group has been set there, don't fret! The function smartly returns whatever value the parent's getNavigationGroup() function carries. It's like the perfect tag-team of functions! 🏆🎈

@RickDBCN
Copy link
Owner

RickDBCN commented Nov 2, 2023

Tests seem to run OK now. Is this ready for review?

@mstfkhazaal mstfkhazaal marked this pull request as ready for review November 7, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants