You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use one project structure for development and publishing.
In the demo application, FeedbackModule is imported directly from ../../projects/ng-feedback/src/public_api to facilitate debugging and development.
html2canvas requirement as peerDependencies. Documentation updated.
Upgrade to Angular 8.
Upgrade to core-js 3.
Imports are given about the standard form, excess removed.
Added script to copy README and LICENSE to distribution.
If this PR supports backward angular versions (7 and 6) compatibility too, could this be merged - In the current version (master) - it doesn't seem to work with my Angular 8 project.
The only compatibility-breaking change is the html2canvas requirement as peerDependency. That is, html2canvas now needs to be installed explicitly in the main project. The installation line in README has been changed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the demo application,
FeedbackModuleis imported directly from../../projects/ng-feedback/src/public_apito facilitate debugging and development.html2canvasrequirement aspeerDependencies. Documentation updated.Thanks so much for a great library!