CSharp client generator - Implementing Async Pattern on PrepareRequest and ProcessResponse

[francozuca]

Issue #3247

[RicoSuter]

We would also need to expose the new config wia CLI command and in the UI (XAML).. can do that tomorrow or you update the PR for that as well. But looks good to me. Thanks.

[francozuca]

We would also need to expose the new config wia CLI command and in the UI (XAML).. can do that tomorrow or you update the PR for that as well. But looks good to me. Thanks.

I just added GeneratePrepareRequestAndProcessResponseAsAsyncMethods to CLI and UI. Please let me know if you want me to rephrase the option description/label. Thanks.

[RicoSuter]

Lgtm, thank you very much.

[jclijmans]

There seems to be an error in this PR.
In /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid when GeneratePrepareRequestAndProcessResponseAsAsyncMethods == true, no partial method definition for PrepareRequestAsync is generated
This results in a generated class that doesn't compile because the PrepareRequestAsync is used later on.

[francozuca]

There seems to be an error in this PR.
In /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid when GeneratePrepareRequestAndProcessResponseAsAsyncMethods == true, no partial method definition for PrepareRequestAsync is generated
This results in a generated class that doesn't compile because the PrepareRequestAsync is used later on.

Hi @jclijmans!
You're right: if GeneratePrepareRequestAndProcessResponseAsAsyncMethods == true, no partial method definition for PrepareRequestAsync is generated.

That is because partial methods cannot be marked as async. So what you should do is to create a partial definition of your client class and then implement those methods in that particular. You can take a look to #3247 where I tried to explain this properly.

Thanks!