-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use as plugin #16
use as plugin #16
Conversation
Hi, thanks for the PR. Also, regarding the tests, I need to fix them. Thanks for all the changes, will review. |
Hi @rsbondi |
your local repo directory followed by it should be executable when you check it out? if not chmod it |
@@ -17,6 +17,7 @@ | |||
"dependencies": { | |||
"atob": "^2.1.2", | |||
"body-parser": "^1.19.0", | |||
"clightningjs": "0.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need to fork this library before adding it to our dependencies. Vary of adding freshly developed libraries, due to security reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is from a very active c-lightning collaborator
https://github.com/ElementsProject/lightning/commits?author=darosior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge in that case. Thanks.
Tested it. Works beautifully. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR. Thanks.
@rsbondi Tests are fixed now in master. Will add more coverage soon. |
This is just to get the conversation started, I think using as a plugin would be beneficial, especially if you are running outside of the default, the plugin knows where to find the rpc file, so configuration easier without needing to launch with env and can be just another entry in the lightning config file, also can be managed from the cli/rpc with the
plugin
command.This was a bit more than I expected with the logging, but hopefully straight forward.
I could not get the tests to pass, not on a fresh install, but I don't see how the macaroon header is set in the tests, but I am probably missing something.
Also, if this looks like a good idea, additional readme update required