Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the property read-back when setting a property #312

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

lleon95
Copy link
Contributor

@lleon95 lleon95 commented Oct 18, 2022

This fixes a bug that issues critical warnings when dealing with write-only properties. When setting this kind of property many times, the number of messages gets unmanageable, and the logs get dirty

Addressing: #275, #313

This fixes a bug when dealing with write-only properties, that issues
critical warnings. When setting this kind of properties many times, the
number of messages gets unmanageable and the logs get dirty
Copy link
Contributor

@migueltaylor migueltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something to the response even if the property is write only? Like "value": null or "value": "WRITE_ONLY".

@lleon95
Copy link
Contributor Author

lleon95 commented Oct 18, 2022

Should we add something to the response even if the property is write only? Like "value": null or "value": "WRITE_ONLY".

Sounds fair to me. I will do it

This adds the implementation of the JSON null. Moreover, it adds the
reaction to WO to set the value to null
This issue addresses the issue with respect to the setting empty strings
(null)
@lleon95 lleon95 merged commit 404ebfa into develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants