Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

🐞 BugFix startup_candle_count #99

Merged
merged 3 commits into from
Aug 14, 2021
Merged

🐞 BugFix startup_candle_count #99

merged 3 commits into from
Aug 14, 2021

Conversation

topscoder
Copy link
Collaborator

Fixes #91

Set actual startup_candle_count only in BACKTEST mode. Probably even in BACKTEST mode it should not be set?

Either way, this patch solves the current HO issue with most recent freqtrade-version (develop).

Set actual startup_candle_count only in BACKTEST mode. Probably even in BACKTEST mode it should not be set?

Either way, this patch solves the current HO issue with most recent freqtrade-version (develop).
@topscoder
Copy link
Collaborator Author

Whoo.. all checks have passed

@Rikj000 Rikj000 linked an issue Jul 20, 2021 that may be closed by this pull request
@Rikj000 Rikj000 added Bug - Fixed Issue has been resolved Needs Testing This feature, improvement or bugfix still is in need of testing labels Jul 20, 2021
@Rikj000 Rikj000 added this to the v0.13.0 milestone Jul 20, 2021
@Rikj000
Copy link
Owner

Rikj000 commented Jul 20, 2021

Reference to reasoning behind BugFix: #91 (comment)

@Rikj000 Rikj000 added the In Progress This is being worked on label Aug 12, 2021
@Rikj000 Rikj000 changed the title Fix hyperopting using most recent freqtrade BugFix startup_candle_count Aug 14, 2021
@Rikj000
Copy link
Owner

Rikj000 commented Aug 14, 2021

While testing this BugFix another bug came to my attention.
The startup_candle_count was not being applied for the informative dataframe.

Before BugFix

BackTesting timeframe - Has correct startup_candle_count:
backtesting_timeframe_correct
Informative timeframe - Has incorrect startup_candle_count (was not being applied):
informative_timeframe_bugged

After BugFix

BackTesting timeframe - Has correct startup_candle_count:
backtesting_timeframe_correct
Informative timeframe - Has correct startup_candle_count:
informative_timeframe_bug_fixed

I already fixed this bug in above commit 1bd3e62 🙂

@Rikj000 Rikj000 removed In Progress This is being worked on Needs Testing This feature, improvement or bugfix still is in need of testing labels Aug 14, 2021
@Rikj000 Rikj000 merged commit 821569c into development Aug 14, 2021
@Rikj000 Rikj000 deleted the topscoder-patch-1 branch August 14, 2021 13:24
@Rikj000 Rikj000 changed the title BugFix startup_candle_count 🐞 BugFix startup_candle_count Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug - Fixed Issue has been resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Fix bugs introduced by updating Freqtrade
2 participants