Associations

[RileyManda]

I have completed the following implementations on the School Library Application according to the stipulated requirements:

The following features were implemented:

Classes

• Created a class Classroom with the following:@Label instance variable, initialized in the constructor.
• Created a Setter and getter for @Label (using attr_accessor).
• Created a class Rental with the following: @Date instance variable,initialized in the constructor.
• Created a Setter and getter for @Date (using attr_accessor).
• Created a class Book with the following:@title and @author instance variables
• Set the classroom for the student.

Associations

• Created the has-many side of Book and Rental (a book has many rentals).
• Created the belongs-to side of Rental and Book (a rental belongs to a book).
• Created the has-many side of Person and Rental (a person has many rentals).
• Created the belongs-to side of Rental and Person (a rental belongs to a person).
• Modified the constructor of Rental so Book and Person are set in it.

In addition, I have fulfilled the following project requirements:

General requirements

• There are no linter errors.
• Used correct Gitflow.
• Documented my work in a professional way.
• Followed the list of best practices for Ruby.

Please kindly review my implementation and suggest any changes and improvements.

I look forward to your feedback.

Thank you 🙏🏻

Best regards,



[Olamarx]

Hi @RileyManda,

Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

• Linters passed ✔️
• Readme file professional ✔️
• Commit messages meaningful ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Olamarx]

• :rentals should also be in the getter and setter so that it could be read and set since we will be adding(setter) data based on some available(getter) data.

[Olamarx]

• In the same vain, there should be an add_rental method here too for the person, it can look as follow:

def add_rental(person, date)
    Rental.new(date, self, person)
  end

[Olamarx]

• As recommended for add_rental method in the book.rb file, it applies here too because it would be adding the book and it should do that itself too.

[RileyManda]

I have completed the following requested changes on the School Library Application:

• Implement add_rental method in Book class
• Implement add_rental method in Person class

Please kindly review my implementation and suggest any changes and improvements.

I look forward to your feedback.

Thank you 🙏🏻

Best regards,

[ichala]

Hi Student ,

Status: Approved ✔️ ✔️ ✔️

To Highlight 💪🏻

• Changes Implemented ✔️

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Optional Suggestions :

• N/A

---

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.