Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/basic UI #5

Merged
merged 12 commits into from
Sep 4, 2023
Merged

Feature/basic UI #5

merged 12 commits into from
Sep 4, 2023

Conversation

RileyManda
Copy link
Owner

@RileyManda RileyManda commented Sep 4, 2023

I have completed the following implementations on the School Library Application according to the stipulated requirements:

The following features were implemented:

Basic UI

  • Created an app.rb file that serves as the console app entry-point with the following methods:
  • List all books. | List all people.
  • Create a person (teacher or student).
  • Create a book.
  • Create a rental.
  • List all rentals for a given person id.
  • Created an main.rb and defined the entry point, with a method called main that is invoked at the end of the file and Presents the user with a list of options to perform.

In addition, I have fulfilled the following project requirements:

General requirements

Linters Tests
Linters Tests

Please kindly review my implementation and suggest any changes and improvements.

I look forward to your feedback.

Thank you 🙏🏻

Best regards,

Copy link

@mukhammadrizooff mukhammadrizooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RileyManda,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✔️
  • Correct GitFlow ✔️
  • Good implementations ✔️
  • Descriptive README file ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@RileyManda RileyManda merged commit 74d6896 into dev Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants