Merge pull request #223 from tanho63/fix/f7slider-iconlabels

fixes to get f7slider labels working
RinteRface · Apr 25, 2022 · 48a7742 · 48a7742
2 parents a5207ce + 44c1f30
commit 48a7742
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,7 @@
 - Fixes #215: Icon not displayed in reconnect / reload toaster. Add f7Icon deps anyway.
 - Fixes #204: issue with `f7DatePicker()` and DST. 
 - Update CI/CD setup.
+- Fixes #222: f7Slider code updated to work with the fix for #215 above. 
 
 
 # shinyMobile 0.9.1

diff --git a/R/f7-inputs.R b/R/f7-inputs.R
@@ -2021,8 +2021,8 @@ f7Slider <- function(inputId, label, min, max, value, step = 1, scale = FALSE,
 
   labels <- if (!is.null(labels)) {
     lapply(seq_along(labels), function(i) {
-      isF7Icon <- (grep(x = labels[[i]][[1]]$attribs$class, pattern = "f7-icons") == 1)
-      if (class(labels[[i]][[1]]) != "shiny.tag" || !isF7Icon) {
+      isF7Icon <- (grep(x = labels[[i]]$attribs$class, pattern = "f7-icons") == 1)
+      if (class(labels[[i]]) != "shiny.tag" || !isF7Icon) {
         stop("Label must be a f7Icon.")
       }
       shiny::tags$div(