-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting separate theme for panels does not work #165
Comments
I'll check but it could be a Framework7 internal issue. If you change the global theme to light, panels have correct CSS. |
I'm having trouble getting the pre-set colors to work: Setting
|
I have a work-around by adding a custom CSS file per F7 documentation:
|
Yes there was an undocumented breaking change in the API. Thanks for reporting it. However, I will now use https://rdrr.io/cran/gplots/man/col2hex.html: gplots::col2hex("red")
[1] "#FF0000" which will avoid this situation so you can pass either the name or the code, like before. |
That being said, |
Thank you. Setting the color option via your suggestion works, but there is still is the problem that the panel menus (left or right) are running a the default colors for the "light" theme (some very light shade of gray?) - hence this CSS workaround:
|
@jpiaskowski and @dmenne : finally found the issue, a bit obvious. In the JS code, the toggleDarkTheme: function() {
var self = this;
var $view = self.$(".view-main");
$view.toggleClass("theme-dark");
} |
…nels can be themeable... Will address #165
After further investigations, my modification breaks many other things like notification style, popovers, ... in dark mode (they appear in grey/white). From the Framework7 documentation, I can set a callback when a widget opens (notification) and add it the Shiny.addCustomMessageHandler(widget, (function(message) {
message.on = {
open: function(target) {
if (target.app.params.dark) $(target.el).addClass("theme-dark");
}
};
app[widget].create(message).open();
})) Keep you updated on the progress ... |
This example is from f7Tab, but any other one would do. The color of the panels is always the base color of the app, different settings are not honoured.
Possibly related: In
shinyMobile.js
, `dark_mode is not defined.The text was updated successfully, but these errors were encountered: