Add RANKED_TFT_PAIRS QueueType #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes current JSON serialization issues due to missing Enum member.
Future ideas:
I have also added a queueTypes.json MingweiSamuel/riotapi-schema#29 and request to add to official docs in RiotGames/developer-relations#574, but am not confident enough to convert this Enum to be auto generated.
Maybe we could also add a UNKNOWN enum member to types that dynamically change with games updates as fallback, so library versions without the new specific member could still work properly for older games modes etc instead of throwing JsonException due to serialization problems?