Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better QueueType enum handling #65

Open
MingweiSamuel opened this issue Nov 20, 2021 · 1 comment
Open

Better QueueType enum handling #65

MingweiSamuel opened this issue Nov 20, 2021 · 1 comment
Labels
enhancement

Comments

@MingweiSamuel
Copy link
Owner

@aPinat #64

Future ideas:
I have also added a queueTypes.json MingweiSamuel/riotapi-schema#29 and request to add to official docs in RiotGames/developer-relations#574, but am not confident enough to convert this Enum to be auto generated.

Maybe we could also add a UNKNOWN enum member to types that dynamically change with games updates as fallback, so library versions without the new specific member could still work properly for older games modes etc instead of throwing JsonException due to serialization problems?
@MingweiSamuel MingweiSamuel mentioned this issue Nov 20, 2021
Closed
@MingweiSamuel
Copy link
Owner Author

Also would help for gameModes, for issues like #84

@aPinat aPinat mentioned this issue Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MingweiSamuel