Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Docs on match-v5 in dev portal are incomplete #603

Closed
geozukunft opened this issue Feb 11, 2022 · 6 comments
Closed

[DOCS] Docs on match-v5 in dev portal are incomplete #603

geozukunft opened this issue Feb 11, 2022 · 6 comments

Comments

@geozukunft
Copy link

It seems like match-v5 matchids had new stats added without any announcement about the new additions. The docs also do not reflect the changes.
Would it be possible to get updated docs cause otherwise using match-v5 endpoints is just guessing work and also helping other people on the 3rd party discord just get's more and more difficult.

Also the timeline endpoint is missing docs completly so no information at all about what data one should expect.

@MingweiSamuel
Copy link

MingweiSamuel commented Feb 11, 2022

Here are the 106 keys for challenges I have found. This is for the new & undocumented challenges field in match-v5.ParticipantDto

Edit: moved to gist to keep things in revisions: https://gist.github.com/MingweiSamuel/d5f9dc40cc5a80a9255e488f27705c56

@geozukunft
Copy link
Author

Seems like new attributes got added again without any docs changes

@MingweiSamuel
Copy link

MingweiSamuel commented Mar 2, 2022

Updated list: https://gist.github.com/MingweiSamuel/d5f9dc40cc5a80a9255e488f27705c56
Total: 118

New values:

"completeSupportQuestInTime",
"dodgeSkillShotsSmallWindow",
"epicMonsterStolenWithoutSmite",
"fasterSupportQuestCompletion",
"kTurretsDestroyedBeforePlatesFall",
"landSkillShotsEarlyGame",
"multiTurretRiftHeraldCount",
"quickCleanse",
"quickFirstTurret",
"quickSoloKills",
"soloTurretsLategame",
"threeWardsOneSweeperCount",

@bbm3h18mpa
Copy link

Hey, are these values guaranteed to show up or are there some values that are sometimes let out?

@MingweiSamuel
Copy link

Hey, are these values guaranteed to show up or are there some values that are sometimes let out?

Some values are sometimes left out

@geozukunft
Copy link
Author

Closing this issue as it predates the release of lol-challenges. I am pointing out that the docs are still missing but issue #633 mentions all missing docs in relation to lol-challenges including those missing on lol-match-v5

@geozukunft geozukunft closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants