Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4 scm is assumed if .git is not a directory #25

Merged
merged 1 commit into from
Sep 25, 2013

Conversation

mgm7734
Copy link

@mgm7734 mgm7734 commented Sep 24, 2013

If, for example, my project is a submodule, then .git will be a file with content: "gitdir: ../.git/modules/mymodule"

This causes "thor scmversion:current" to fail while attempting nonexistent p4 commands.

@capoferro
Copy link
Contributor

Thanks!

capoferro added a commit that referenced this pull request Sep 25, 2013
P4 scm is assumed if .git is not a directory
@capoferro capoferro merged commit a74996b into RiotGamesMinions:master Sep 25, 2013
@johntdyer johntdyer mentioned this pull request Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants