Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding string URL #1770

Closed
wants to merge 2 commits into from
Closed

Encoding string URL #1770

wants to merge 2 commits into from

Conversation

jlechem
Copy link

@jlechem jlechem commented Oct 18, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • [X ] a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Please add details about your change here.
Adding string encoding of URLS in http util

Testing

Required verification:

  • [ X] I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • [ X] I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • [ X] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

Adding directory creation to selecting save file
@jlechem jlechem closed this by deleting the head repository Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant