Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving #1777. Xhamster now downloading all images in album. #1788

Closed
wants to merge 4 commits into from

Conversation

mukulj77
Copy link

@mukulj77 mukulj77 commented Nov 8, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Please add details about your change here.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@mukulj77
Copy link
Author

mukulj77 commented Nov 8, 2020

The #1777 codefix.

This is an expansive change. Added the fasterxml.jackson package to POM
for parsing the JSON object. TO-DO: Need to check the test cases.
Just improving the bug-fix. TO-DO: Need to check the test cases.
Conflicts:
	src/main/java/com/rarchives/ripme/ripper/rippers/XhamsterRipper.java
@soloturn
Copy link
Contributor

if you could squash the commits and give a commit comment describing why you changed what would be extremely cool. i merged it and published it here as is, just to see if the tests work:
https://github.com/soloturn/ripme/tree/main

@mukulj77
Copy link
Author

if you could squash the commits and give a commit comment describing why you changed what would be extremely cool. i merged it and published it here as is, just to see if the tests work:
https://github.com/soloturn/ripme/tree/main

Actually, this solution no longer works because looks like this week, the revised more changes on the webpage. So, I'm closing this PR without merging it. I'll raise a new request after testing the updated solution.

@mukulj77 mukulj77 closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants