Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVVM #161

Closed
wants to merge 6 commits into from
Closed

MVVM #161

wants to merge 6 commits into from

Conversation

esibruti
Copy link
Contributor

@esibruti esibruti commented Mar 31, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots / Videos (optional)
Add screenshots and/or videos here.

@itsWindows11
Copy link
Collaborator

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@esibruti
Copy link
Contributor Author

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

@itsWindows11
Copy link
Collaborator

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

I know, just don't want some collaborator to accidentally click on the merge button and break everything we did (for example in #159)

@esibruti
Copy link
Contributor Author

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

I know, just don't want some collaborator to accidentally click on the merge button and break everything we did (for example in #159)

I don't even want to imagine the headache that would be but yes, I understand that. No problem.

@esibruti esibruti deleted the mvvm branch April 1, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants