Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full responsiveness #2

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

Muz4mmil
Copy link
Contributor

Resolves #1
Closes #1
Hey @RishabhJain0721 , I am doing a PR directly to master branch. Kindly check and Merge it under hacktoberfest and hacktoberfest-accepted tags and labels.

@vercel
Copy link

vercel bot commented Oct 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @RishabhJain0721 on Vercel.

@RishabhJain0721 first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
brain-box ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 7:50am

@RishabhJain0721 RishabhJain0721 merged commit d19bb02 into RishabhJain0721:master Oct 29, 2023
1 check passed
@Muz4mmil
Copy link
Contributor Author

Screenshot_20231029-132508_Chrome

@RishabhJain0721 Hello bro,
As soon as you merged the PR, it shows not accepted in hacktoberfest page.
Do you have any idea??
Also, can you try adding hacktoberfest-accepted label too...
It was a tough work taking that subject pane to nav menu, I want this issue to get counted

@RishabhJain0721
Copy link
Owner

I have merged your PR.
A tip : Don't push any code having some API key directly. Use a .env file to manage it.

@Muz4mmil
Copy link
Contributor Author

I have merged your PR. A tip : Don't push any code having some API key directly. Use a .env file to manage it.

Yeah thanks for merging.
But I just forked your repo, cloned, made changes and created PR. I didn't touched any api or your Firebase config

@RishabhJain0721
Copy link
Owner

@Muz4mmil Hello bro
I am sorry you are facing this.
I have added all required labels, don't know why it's happening.

@RishabhJain0721
Copy link
Owner

I have merged your PR. A tip : Don't push any code having some API key directly. Use a .env file to manage it.

Yeah thanks for merging. But I just forked your repo, cloned, made changes and created PR. I didn't touched any api or your Firebase config

It was in your commit history so I assume it was done by some mistake. Alright now I have changed it.

@Muz4mmil
Copy link
Contributor Author

@Muz4mmil Hello bro I am sorry you are facing this. I have added all required labels, don't know why it's happening.

Uhh okay no issues,
By the way how's the app now?
Do you want any changes?

Also note that, it is not realtime responsive, I mean if you want to check the responsiveness, you have to reload the page every time you change the screen ( that's not an issue I guess )

@RishabhJain0721
Copy link
Owner

@Muz4mmil Hello bro I am sorry you are facing this. I have added all required labels, don't know why it's happening.

Uhh okay no issues, By the way how's the app now? Do you want any changes?

Also note that, it is not realtime responsive, I mean if you want to check the responsiveness, you have to reload the page every time you change the screen ( that's not an issue I guess )

It's definitely looking better then before. That sidebar is really nice.
I don't want any changes as of now.
That's not a big issue, can be ignored.

Thanks for contributing. 👍🏻

@Muz4mmil
Copy link
Contributor Author

Hey @RishabhJain0721
Now the PR is getting counted, I don't know how 😂.
Thanks for supporting and sorry for inconvenience, I am new to Open source and still learning how stuff works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make application responsive
2 participants