-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applied Definition Queries to BRAT #333
Conversation
While this was corrected for Q and Web, it never got fixed for ArcRAVE.
This is to force default display to show only perennial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the queries themselves but the format looks right. Keep in mind these layers won't mean very much in webRave unless you also come up with associated symbologies that do the same thing as the queries
Sorry I am not following @MattReimer? My expectation is that for now these layers will all look exactly the same even though access from two places in business logic because WebRAVE does not yet handle definition queries? My assumption was that when WebRAVE does, tippicanoe (or whatver generates vector tiles), would genearate its tiles for each layer exposed at each node in the business logic. So in this case, capacity with the definition query would display what it should, and it without the defnition query would display everything? I didn't intend to have any different symbology. |
It all depends what your query is doing. If you intend to remove features that would normally be visible then webRAVE would need an accompanying symbology to do the same thing. Nothing in the project --> tiles --> webrave pipeline has filtering ability except the symbology. If all you're doing is filtering the data table to hide things that aren't visible on the map anyway then you're fine. We can talk about this more tomorrow if you'd like just so we're not loudly agreeing with each other. This stuff is hard to talk about and I may not totally grasp what's going on here |
WebRAVE only ever makes a single vector tile set for each layer. A single vector tile set is shared by all layers that display the same feature class. So in your sqlBRAT example, a single BRAT tile set is used for historic as existing. You get the same features in both layers. There is no concept or ability to implement definition queries on the client. The way to mimic definition querries in webRAVE is to use symbology to filter out features with the desired attributes. |
Cool. I'll just merge this so you can play with it. We can roll back changes if anything isn't working as intended. |
FYI @MattReimer and @philipbaileynar. Just tested on six Bear River BRAT projects and the def queries in Arc are working perfectly. LMK when I should test in QRAVE (saw @KellyMWhitehead made that change). So much better. |
Hey @MattReimer and @philipbaileynar. Related to Riverscapes/RaveAddIn#176 (comment), I modified the business logic so this will work how we want for what to display. I know this will not yet work for WebRAVE, but I did test it on ArcRAVE (see video). It should work on QRAVE too when @KellyMWhitehead finishes those updates.