Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Linter] False positive in T001 with embedded JS curly braces #606

Closed
3 tasks done
alexrudd2 opened this issue Apr 21, 2023 · 3 comments · Fixed by #691
Closed
3 tasks done

[BUG] [Linter] False positive in T001 with embedded JS curly braces #606

alexrudd2 opened this issue Apr 21, 2023 · 3 comments · Fixed by #691
Labels
🔍 linter 🦠 bug Something isn't working released

Comments

@alexrudd2
Copy link

System Info

  • OS: MacOS Ventura
  • Python Version 3.11.0
  • djLint Version 1.23.1
  • template language: jinja

Issue & how to reproduce

T001 False positive on

<button onclick="util.request(`set`, {to_set : {tags: ''}});">

Contents of .djlintrc

{
  "indent": "2",
  "max_attribute_length": "120",
  "max_line_length": "120",
  "ignore": "H021,H006,H023,H013,T028,H030,H031,H020"
}

Thanks for the tool, it's great!
@alexrudd2 alexrudd2 added 🔍 linter 🦠 bug Something isn't working labels Apr 21, 2023
@welcome
Copy link

welcome bot commented Apr 21, 2023

Thanks for opening your first issue here!

@christopherpickering
Copy link
Contributor

@alexrudd2 sorry for the delay.. should get this out in a release today.

Merged
2 tasks
christopherpickering pushed a commit that referenced this issue Jun 12, 2023
@semantic-release-bot
chore(release): 1.31.0 [skip ci]
485738d 
# [1.31.0](v1.30.2...v1.31.0) (2023-06-12)

### Bug Fixes

* **formatter:** fixed `line_break_after_multiline_tag` to force break in all cases ([3b37ec8](3b37ec8)), closes [#680](#680)
* **formatter:** fixed isolated quotes being deleted from attributes ([19425f9](19425f9)), closes [#652](#652)
* **formatter:** fixed wild match on template tags ([d288b78](d288b78)), closes [#686](#686)
* **linter:** fixed false positive on t001 ([1caf4c4](1caf4c4)), closes [#606](#606)

### Features

* **formatter:** added `max-blank-lines` flag to consolidate blank lines ([4a7897f](4a7897f)), closes [#675](#675)
* **formatter:** added support for symphony forms ([e716ddc](e716ddc)), closes [#476](#476)
@christopherpickering
Copy link
Contributor

🎉 This issue has been resolved in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 linter 🦠 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps) Update all non-major dependencies djlint/djLint
2 participants
@christopherpickering @alexrudd2