Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted fetch requests to useSWR hooks & changed pull request to dev branch #36

Merged
merged 13 commits into from
Sep 21, 2021
Merged

converted fetch requests to useSWR hooks & changed pull request to dev branch #36

merged 13 commits into from
Sep 21, 2021

Conversation

brownboycodes
Copy link
Contributor

responding to issue #32 Convert fetch api calls to SWR

In this pull request, I have :

  1. created a new branch implement-swr
  2. added SWR as a dependency 📦
  3. have converted the fetch requests into implementations of useSWR hooks in /components/formwrapper.js 🏗️ 🔨 ✨
  4. added comments to understand which parts of the code has been replaced 💡

I would be happy if I have been of any help and would appreciate your feedback

@brownboycodes brownboycodes changed the title Implement swr converted fetch requests to useSWR hooks & changed pull request to dev branch Sep 20, 2021
@vercel
Copy link

vercel bot commented Sep 21, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @RizkyRajitha on Vercel.

@RizkyRajitha first needs to authorize it.

@RizkyRajitha RizkyRajitha merged commit f015631 into RizkyRajitha:dev Sep 21, 2021
@RizkyRajitha
Copy link
Owner

@brownboycodes thanks for your valuable contribution 👌 .

@brownboycodes
Copy link
Contributor Author

@RizkyRajitha can I mention my contributions to LinkIn Demo on my Resume & LinkedIn (as contribution to Open Source Projects)?

@RizkyRajitha
Copy link
Owner

@brownboycodes yup ,no problem .
this is actually Linkin, not linkin demo 🙄.

@brownboycodes
Copy link
Contributor Author

brownboycodes commented Sep 21, 2021

@RizkyRajitha didn't mean to offend ya mate, I know it is Linkin, its just that when I opened the application 2days ago it said LinkIn Demo under the avatar and that naming convention stuck to my head cuz whenever I deploy my projects I deploy as if it is the final product even though there are tons of changes to be made so have been thinking suffixing 'demo' to names of my project would be a good practice...
anyways I am tryin out creating proper UI test cases too for Linkin

@RizkyRajitha
Copy link
Owner

@brownboycodes sorry, i think you got the emoji wrong , i am not offended in anyway why would i , you just made a valuable contribution to this project , and i appreciate that very much .
i just corrected you , because there is a demo version too https://github.com/RizkyRajitha/linkindemo , and this is not that one .
excited to see more contributions from you ✌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants