Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor predefinedSelections update function #209

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

mdroidian
Copy link
Collaborator

from these changes: #146

oldValue wasn't updated to previousValue which is:

      const previousValue = toCellValue({
        value: result[columnKey],
        uid: columnUid?.toString(),
      });

If the selection label was different than data (attribute name), oldValue would return "" and prepend the block with the new value.

eg:
as status select Status
as abc select Status

@mdroidian mdroidian merged commit 2ce61e6 into main Jan 3, 2024
1 check passed
@mdroidian mdroidian deleted the predefined-selections-update-fix branch January 3, 2024 23:36
@mdroidian mdroidian restored the predefined-selections-update-fix branch January 3, 2024 23:37
@mdroidian mdroidian deleted the predefined-selections-update-fix branch January 3, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants