Add Feature: Attribute Select #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdroidian
commented
Sep 7, 2023
src/features/attributeSelect.tsx
Outdated
Comment on lines
239
to
275
| const ConfigPage = ({}: {}): React.ReactElement => { | ||
| const titleRef = useRef<HTMLDivElement>(null); | ||
| return ( | ||
| <Card style={{ color: "#202B33" }} className={"roamjs-config-panel"}> | ||
| <div | ||
| style={{ display: "flex", justifyContent: "space-between" }} | ||
| ref={titleRef} | ||
| tabIndex={-1} | ||
| > | ||
| <h4 style={{ padding: 4 }}>Attribute Select Configuration</h4> | ||
| </div> | ||
| <AttributeConfigPanel /> | ||
| </Card> | ||
| ); | ||
| }; | ||
| const renderConfigPage = ({ | ||
| h, | ||
| pageUid, | ||
| }: { | ||
| h: HTMLHeadingElement; | ||
| pageUid: string; | ||
| }) => { | ||
| const uid = pageUid; | ||
| const attribute = `data-roamjs-${uid}`; | ||
| const containerParent = h.parentElement?.parentElement; | ||
| if (containerParent && !containerParent.hasAttribute(attribute)) { | ||
| containerParent.setAttribute(attribute, "true"); | ||
| const parent = document.createElement("div"); | ||
| const configPageId = "attribute-select"; | ||
| parent.id = `${configPageId}-config`; | ||
| containerParent.insertBefore( | ||
| parent, | ||
| h.parentElement?.nextElementSibling || null | ||
| ); | ||
| ReactDOM.render(<ConfigPage />, parent); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Pulled this out because
- I was having issue with duplicate blocks being created
- had to CSS hide multiple tabs
Turns out the multiple blocks issue was solved elsewhere, so I could go back to using roamjs createConfigObserver
mdroidian
commented
Sep 7, 2023
dvargas92495
requested changes
Sep 10, 2023
|
tagging @dvargas92495 just for visibility Here's a video with some of the changes since the first video WorkBench.-.Attribute.Select.-.14.September.2023.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/b7648ed545ff42b4bff6aacc42461ee2
before this PR:
probably also
<Tab>on deleteWould be nice
Future Additions
[[``]]#chevron-downshould just display the blueprintjsSelectwithout a button or "overlay"Add an Attributeis clicked, menu should be already open and displayed