blip-29: add swap_type field to RFQ request message schema
#2
Conversation
This commit adds a `swap_type` field to the RFQ (Request for Quote) request message schema. The purpose of this field is to specify the desired swap type in the request. It enables the sender of the request message to clearly define whether they are seeking to exchange a Tap asset for BTC or vice versa. The addition of the `swap_type` field enhances the versatility of the RFQ request message.
ffranr
force-pushed
the
rfq-request-direction
branch
from
c60063a
to
030d89f
Compare
|
In the future, this new field may enable the signaling of various swap types, such as those allowing for the partial fulfillment of quotes at the agreed rate, among other possibilities. |
| * `swap_type` is the type of swap the message sender is requesting. When the | ||
| `swap_type` is `1`, the sender is requesting a swap of their Tap asset for | ||
| BTC. When the `swap_type` is `2`, the sender is requesting a swap of their | ||
| BTC for the subject Tap asset. |
There was a problem hiding this comment.
To support a more asset-agnostic/extensible way of referring to this direction, how about we modify the field to be: in_asset / out_asset
There was a problem hiding this comment.
@dstadulis But one of the assets is always forced by the blockchain LN runs on, right? Why specify that?
There was a problem hiding this comment.
modify the field to be:
in_asset/out_asset
I'm not sure I understand what you mean. Do you mean modify the swap_type field name? Or the asset_id field name? Or the way swap_type is documented?
When generalizing, we need to make sure we have all the necessary fields for it to make sense. Right now, we're only specifying one asset with asset_id and don't have any other field to mention another asset.
There was a problem hiding this comment.
PR which takes the in/out asset approach: #3
There was a problem hiding this comment.
This concept continues implementation here #3
This commit adds a
swap_typefield to the RFQ (Request for Quote) request message schema. The purpose of this field is to specify the desired swap type in the request. It enables the sender of the request message to clearly define whether they are seeking to exchange a Tap asset for BTC or vice versa. The addition of theswap_typefield enhances the versatility of the RFQ request message.