Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added getImmediateMethods #128

Merged
merged 1 commit into from
Oct 27, 2015
Merged

added getImmediateMethods #128

merged 1 commit into from
Oct 27, 2015

Conversation

digitalkaoz
Copy link
Contributor

  • enables us to get the direkt methods (like it already exists for interfaces)
  • fixed the IdentifierException to be able to get the Identifier back

@asgrim
Copy link
Member

asgrim commented Sep 17, 2015

@digitalkaoz thanks, but could you create two separate PRs for these? also tests failing >.<

@asgrim asgrim self-assigned this Sep 17, 2015
@asgrim asgrim added this to the 1.0.0 milestone Sep 17, 2015
@digitalkaoz
Copy link
Contributor Author

currently fixing them...some tests are very hard to understand...ill split that up

@digitalkaoz
Copy link
Contributor Author

identifier fix see #129

@digitalkaoz digitalkaoz force-pushed the feature/immediate_methods branch 2 times, most recently from f154683 to 41df702 Compare September 17, 2015 14:02
@digitalkaoz
Copy link
Contributor Author

the rest is fixed here

@asgrim
Copy link
Member

asgrim commented Sep 17, 2015

@digitalkaoz needs tests please

@digitalkaoz
Copy link
Contributor Author

oh forgot to ammend them...now they are there

@asgrim asgrim mentioned this pull request Oct 27, 2015
Merged
@asgrim asgrim merged commit 356dc26 into Roave:master Oct 27, 2015
@digitalkaoz digitalkaoz deleted the feature/immediate_methods branch October 27, 2015 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asgrim asgrim

Labels
enhancement
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@digitalkaoz @asgrim