Added FindReflectionOnLine helper utility #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sebastianbergmann - have you had a chance to look over this change, and whether it's suitable for your needs, please? |
|
Not yet, sorry. Hopefully tomorrow. |
|
I had a chance to look at this and it does what I need. Thanks! Can you explain, though, why you chose to implement this as a functor (using |
|
The class has a single purpose, so no need for any other public API really. Can be used throw-away, for example in PHP 7, something like this should work (didn't check syntax btw): $reflection = (new FindReflectionOnLine)($file, $line); |
|
This is good to go: merging! |
Ocramius
added a commit
that referenced
this pull request
Mar 11, 2016
Added FindReflectionOnLine helper utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt number 2 and solving #178 in a nicer way.
This provides an API as per the documentation written in
docs/find-reflection-on-line.md.