Implemented ReflectionMethod::getClosure() #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
kukulich
force-pushed
the
get-closure
branch
from
7514585
to
811226b
Compare
Ocramius
approved these changes
Sep 4, 2017
src/Reflection/ReflectionMethod.php
Outdated
| private function assertClassExist(string $className) : void | ||
| { | ||
| if ( ! \class_exists($className, false)) { | ||
| throw new ClassDoesNotExist('Method cannot be used as the class is not loaded'); |
There was a problem hiding this comment.
Please add the class name to the exception
|
Ah, and a rebase will be needed, sorry :-\ |
kukulich
force-pushed
the
get-closure
branch
from
811226b
to
d327ee2
Compare
|
@Ocramius No problem, done :) |
|
Good to go! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.