Implemented missing functions in ReflectionFunction #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Ocramius
requested changes
Sep 5, 2017
| */ | ||
| public function invokeArgs(array $args = []) | ||
| { | ||
| $this->assertIsNoClosure(); |
There was a problem hiding this comment.
Why can't you call it on a function?
There was a problem hiding this comment.
I think that the only possible solution for invokeArgs working for closures is to build PHP code from AST and use eval. And it will fail anyway for code like this:
<?php
class Foo
{
private $foo = 'foo';
public function boo()
{
return (function () {
return $this->foo;
})();
}
}There was a problem hiding this comment.
Ah, got it. Didn't consider that the closure wasn't loaded yet.
|
Thanks @kukulich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.