Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of ReflectionClass::export/ReflectionObject::export to match behaviour of core classes #479

Merged
merged 4 commits into from
Jun 7, 2019

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Jun 5, 2019

Replaces #397 from @muglug - I've rebased onto latest master, and implemented the proposal.

Note: introduces a BC break, so definitely targeting 4.0.0 for this.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asgrim should we close the 3.x milestones?

@asgrim
Copy link
Member Author

asgrim commented Jun 7, 2019

@Ocramius sure, if we want to go from 3.5 to 4.0 👍 I'm fine with that

@Ocramius Ocramius merged commit 4584ced into master Jun 7, 2019
@Ocramius Ocramius deleted the fix-exports branch June 7, 2019 09:43
@Ocramius
Copy link
Member

Ocramius commented Jun 7, 2019

Right, from now on master is only dedicated to 4.0.0. @asgrim @kukulich if you have patches with BC Breaks, don't be scared to break it ;-)

@Ocramius
Copy link
Member

Ocramius commented Jun 7, 2019

Fun times! Merging this resulted in following (something in dependencies):

There was 1 error:
1) Roave\BetterReflectionTest\Reflection\Adapter\ReflectionMethodTest::testAdapterMethods with data set #8 ('getDocComment', null, false, array())
TypeError: Return value of Mock_ReflectionMethod_15775ca8::getDocComment() must be of the type string, boolean returned
C:\Users\travis\build\Roave\BetterReflection\src\Reflection\Adapter\ReflectionMethod.php:109
C:\Users\travis\build\Roave\BetterReflection\test\unit\Reflection\Adapter\ReflectionMethodTest.php:130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants