Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed wrong classes and functions from PHPStorm stubs map #482

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kukulich
Copy link
Collaborator

No description provided.

@theofidry
Copy link
Contributor

Will need to port that to JetBrains/phpstorm-stubs#614

@asgrim
Copy link
Member

asgrim commented Jun 12, 2019

@theofidry do we want to block this until upstream is merged?

@asgrim asgrim self-assigned this Jun 12, 2019
@asgrim asgrim added this to the 4.0.0 milestone Jun 12, 2019
@theofidry
Copy link
Contributor

theofidry commented Jun 12, 2019

No it's alright :)

@asgrim
Copy link
Member

asgrim commented Jun 12, 2019

Alrighty, thanks!

@asgrim asgrim merged commit f86b8f9 into Roave:master Jun 12, 2019
@asgrim
Copy link
Member

asgrim commented Jun 12, 2019

Thanks @kukulich !

@Ocramius
Copy link
Member

Note: this is still targeting 4.0.0. Do you need a fix in the current stable release, @kukulich?

@kukulich
Copy link
Collaborator Author

It could be in 3.5.1 but it's probably not important. I don't think somebody would use class name ___PHPSTORM_HELPERS\\PS_UNRESERVE_PREFIX_static :)

@kukulich kukulich deleted the phpstorm-stubs branch December 20, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants