Add compatibility with Composer v2 installed.json files #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installed.json is now a map with one entry for packages containing the same former array of packages.
naderman
commented
Jan 20, 2020
test/unit/SourceLocator/Type/Composer/Factory/MakeLocatorForComposerInstalledJsonTest.php
Show resolved
Hide resolved
Ocramius
approved these changes
Jan 20, 2020
| throw FailedToParseJson::inFile($installedJsonPath); | ||
| } | ||
|
|
||
| /** @var list<array{name: string, autoload: array{classmap: array<int, string>, files: array<int, string>, psr-4: array<string, array<int, string>>, psr-0: array<string, array<int, string>>}}>|null $installed*/ | ||
| $installed = $installedJson['packages'] ?? $installedJson; |
There was a problem hiding this comment.
If I understand this correctly, 2.0 will have the packages moved one level down? Can't this BC break be prevented overall, if the structure was preserved, and a separate metadata file was added?
There was a problem hiding this comment.
Yes that's all that happened. The file is now a map of values, so we can add elements to it in the future without BC breaks. I think the goal was not to add even more metadata files, and rather accept that 2.0 is a BC break anyway and reformat this in a way allowing for future modification without BC breaks. cc @Seldaek
test/unit/SourceLocator/Type/Composer/Factory/MakeLocatorForComposerInstalledJsonTest.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installed.json is now a map with one entry for packages containing the same former array of packages.