Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CS #578

Merged
merged 1 commit into from
May 27, 2020
Merged

Updated CS #578

merged 1 commit into from
May 27, 2020

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich
Copy link
Collaborator Author

Broken build is unrelated - will try to fix in different PR.

@asgrim
Copy link
Member

asgrim commented May 22, 2020

Can rebase this for a green build probably now :)

@asgrim asgrim self-assigned this May 26, 2020
@asgrim asgrim added this to the 4.3.0 milestone May 26, 2020
asgrim
asgrim requested changes May 26, 2020
View reviewed changes
Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase please

@kukulich
Copy link
Collaborator Author

kukulich commented May 26, 2020 •
edited
Loading

In the pub after three months 😀 will do later/tomorrow

@asgrim
Copy link
Member

asgrim commented May 26, 2020

Cheers! 🍻 😆

@kukulich
Copy link
Collaborator Author

Rebased.

@Ocramius
Copy link
Member

CI went through: 🚢

@Ocramius Ocramius merged commit 3dc1942 into Roave:master May 27, 2020
@Ocramius Ocramius self-assigned this May 27, 2020
@kukulich kukulich deleted the cs branch May 27, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgrim asgrim asgrim requested changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

@asgrim asgrim

Labels
enhancement
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kukulich @asgrim @Ocramius