Pretty much compatible ReflectionMethod

[asgrim]

Created new issue for getPrototype() cuz there's some janky logic there - see #57 plus we need to finish ReflectionClass first.

This resolves the ReflectionMethod item on #7.

[GeeH]

Does getInterfaces() work?

On Fri, 10 Jul 2015 at 13:33 James Titcumb notifications@github.com wrote:

Created new issue for getPrototype() cuz there's some janky logic there -
see #57 #57 plus we
need to finish ReflectionClass first.

This resolves the ReflectionMethod item on #7

#7.

You can view, comment on, or merge this pull request online at:

#58
Commit Summary

• Added ReflectionMethod->getModifiers()
• Added incomplete implementation of ReflectionMethod->getPrototype()
• Updated compatibility.md

File Changes

• M docs/compatibility.md
  https://github.com/Roave/BetterReflection/pull/58/files#diff-0 (52)
• A src/Reflection/Exception/MethodPrototypeNotFound.php
  https://github.com/Roave/BetterReflection/pull/58/files#diff-1 (7)
• M src/Reflection/ReflectionMethod.php
  https://github.com/Roave/BetterReflection/pull/58/files#diff-2 (35)
• A test/unit/Fixture/PrototypeTree.php
  https://github.com/Roave/BetterReflection/pull/58/files#diff-3 (31)
• M test/unit/Reflection/ReflectionMethodTest.php
  https://github.com/Roave/BetterReflection/pull/58/files#diff-4 (43)

Patch Links:

• https://github.com/Roave/BetterReflection/pull/58.patch
• https://github.com/Roave/BetterReflection/pull/58.diff

—
Reply to this email directly or view it on GitHub
#58.

[Ocramius]

$val = ($this->isStatic() & \ReflectionMethod::IS_STATIC)
    | ($this->isPublic() & \ReflectionMethod::IS_PUBLIC)
    | ($this->isProtected() & \ReflectionMethod::IS_PROTECTED)
    | ($this->isPrivate() & \ReflectionMethod::IS_PRIVATE)
    | ($this->isAbstract() & \ReflectionMethod::IS_ABSTRACT)
    | ($this->isFinal() & \ReflectionMethod::IS_FINAL)
    | ($this->isStatic() & \ReflectionMethod::IS_STATIC)
    | ($this->isStatic() & \ReflectionMethod::IS_STATIC);

[Ocramius]

Example is broken btw. true & 1 === 1, true & 2 === 0

[Ocramius]

$val = ($this->isStatic() ? 0 : \ReflectionMethod::IS_STATIC)
    | ($this->isPublic() ? 0 : \ReflectionMethod::IS_PUBLIC)
    | ($this->isProtected() ? 0 : \ReflectionMethod::IS_PROTECTED)
    | ($this->isPrivate() ? 0 : \ReflectionMethod::IS_PRIVATE)
    | ($this->isAbstract() ? 0 : \ReflectionMethod::IS_ABSTRACT)
    | ($this->isFinal() ? 0 : \ReflectionMethod::IS_FINAL)
    | ($this->isStatic() ? 0 : \ReflectionMethod::IS_STATIC)
    | ($this->isStatic() ? 0 : \ReflectionMethod::IS_STATIC);

So yeah, ternaries -.-

[asgrim]

That.. also doesn't work.

[Ocramius]

Alright, guess I'll just be ok with the current approach.

[asgrim]

@GeeH getInterfaces() does not yet work - I thought you were implementing it? ;)

[Ocramius]

👍