Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectionSourceStubber should generate types of properties #637

Merged
merged 1 commit into from
Jun 1, 2020
Merged

ReflectionSourceStubber should generate types of properties #637

merged 1 commit into from
Jun 1, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Jun 1, 2020

No description provided.

@Ocramius Ocramius changed the title ReflectionSourceStubber should generate types to properties ReflectionSourceStubber should generate types of properties Jun 1, 2020
Ocramius
Ocramius approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius added this to the 4.4.0 milestone Jun 1, 2020
@Ocramius Ocramius self-assigned this Jun 1, 2020
@Ocramius Ocramius merged commit 13d9aa7 into Roave:master Jun 1, 2020
@Ocramius
Copy link
Member

Ocramius commented Jun 1, 2020 •
edited
Loading

Nice improvement! Wasn't expecting stubs to already have types for properties :)

EDIT: nvm, it's the reflection fallback stubber 👍

@kukulich kukulich deleted the properties branch June 1, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius