Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Reflection/ReflectionFunctionAbstract::isGenerator() for functions with yield from #650

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fixed Reflection/ReflectionFunctionAbstract::isGenerator() for functions with yield from #650

merged 1 commit into from
Jun 9, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Jun 9, 2020

Fixes #644

Ocramius
Ocramius approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@Ocramius Ocramius added this to the 4.5.0 milestone Jun 9, 2020
@Ocramius Ocramius self-assigned this Jun 9, 2020
@Ocramius Ocramius added the bug label Jun 9, 2020
@Ocramius Ocramius merged commit 9982305 into Roave:master Jun 9, 2020
@kukulich kukulich deleted the yield branch June 9, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

ReflectionFunctionAbstract does not recognize body with yield from as generator
2 participants
@kukulich @Ocramius