Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectionMethod::getPrototype() should report implementing vlass prototype, and skip constructors #656

Merged
merged 1 commit into from
Jun 10, 2020
Merged

ReflectionMethod::getPrototype() should report implementing vlass prototype, and skip constructors #656

merged 1 commit into from
Jun 10, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Jun 9, 2020

Fixes #640
Fixes #639

Ocramius
Ocramius approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks @kukulich!

@Ocramius Ocramius added the bug label Jun 10, 2020
@Ocramius Ocramius added this to the 4.5.0 milestone Jun 10, 2020
@Ocramius Ocramius self-assigned this Jun 10, 2020
@Ocramius Ocramius changed the title ReflectionMethod::getPrototype() fixes ReflectionMethod::getPrototype()` should report implementing vlass prototype, and skip constructors Jun 10, 2020
@Ocramius Ocramius changed the title ReflectionMethod::getPrototype()` should report implementing vlass prototype, and skip constructors ReflectionMethod::getPrototype() should report implementing vlass prototype, and skip constructors Jun 10, 2020
@Ocramius Ocramius merged commit 18bb4a7 into Roave:master Jun 10, 2020
@kukulich kukulich deleted the prototype branch June 10, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.5.0
2 participants
@kukulich @Ocramius