Internal class reflections #80

asgrim · 2015-07-20T22:47:58Z

This PR fixes #38

AggregateSourceLocators can be nested now (Reflector\Generic will recurse through them in a flat ordered way)
I had to modify the behaviour of the SourceLocators slightly so that they don't throw exceptions, but merely return null. This is so that when we loop through the AggregateSourceLocator, we don't break the loop.
By default PhpInternalSourceLocator gets added to all calls to reflect(). Can be disabled by a paramter
A new magic const is defined as a flag to notify ReflectionClass that the LocatedSource originated from the PhpInternalSourceLocator (thus isInternal() === true)

Todo

Needs the rest of the internal classes implemented...
~~~Need to implement functions too...~~~
More path coverage for PhpInternalSourceLocator

…er so that SourceLocator aggregates can work properly

Ocramius · 2015-07-21T20:39:13Z

src/SourceLocator/AggregateSourceLocator.php

@@ -30,7 +30,13 @@ public function __construct(array $sourceLocators = [])
    public function __invoke(Identifier $identifier)
    {
        foreach ($this->sourceLocators as $sourceLocator) {
-            yield $sourceLocator->__invoke($identifier);
+            if ($sourceLocator instanceof self) {


Why not just if ($sourceLocator instanceof Traversable) {?

'cuz AggregateSourceLocator is not Traversable?

…lection

…als code

… should be reflectable and produce an InternalLocatedSource

…nstances when producing a result

…d eval'd classes

…eness

…stubbing Internal class reflections runtime stubbing

Internal class reflections

asgrim added 5 commits July 20, 2015 22:24

Added stub for stdClass as POC for internal class reflection

81702a0

Added flag for identifying when internal source is used

20836fc

Support nested AggregateSourceLocators

78cbcaf

Modified SourceLocator classes to return null if cannot find identifi…

d59cf43

…er so that SourceLocator aggregates can work properly

By default, add the PhpInternalSourceLocator

f1dc199

asgrim added the reflection compatibility label Jul 20, 2015

asgrim self-assigned this Jul 20, 2015

asgrim added this to the 1.0.0 milestone Jul 20, 2015

Fixed @Covers annotation

2b28466

Ocramius reviewed Jul 21, 2015
View reviewed changes

Ocramius added 18 commits July 22, 2015 00:22

Documenting constructor parameters

73ac4bd

CompileNodeToValue should consider negative values as well

c8f2f54

Handling negative values in CompileNodeToValue

336d9aa

Upgrading to PHP7-compatible parser by @nikic because #yolo

4439ef4

Initial testing: internal reflector MUST support internal classes ref…

ed43548

…lection

Initial implementation of a source locator capable of stubbing intern…

f429f19

…als code

Specification for InternalLocatedSource

eaeb8d7

Implementing EvaledLocatedSource

eaf6712

Accurately testing the internal source locator - all internal classes…

c8c5758

… should be reflectable and produce an InternalLocatedSource

Removing useless hint

d297cbb

Internal sources shalt be internal sources forever

fff7c18

The internal source locator should retrieve InternalLocatedSource i…

08b7da5

…nstances when producing a result

LocatedSource#isEvaled() specification

b29dd2a

isEvaled base implementation, removing clutter that isn't needed

9625c98

EvaledLocatedSource implementation and tests

5800109

Correcting SUT class

b92828d

Basic EvaledCodeSourceLocator implementation

9e56d5f

Testing evaluation of eval()'d source classes

745408b

Ocramius and others added 6 commits July 22, 2015 01:36

Stricter evaluation of eval'd code output

30036c8

Verifying trait/interface evaluation

0c4270a

Correcting return type hint (file may not exist)

ed13185

By default, ReflectionClass should be able to deal with internal an…

3989ea0

…d eval'd classes

Switching to the composite source locator by default, for more awesom…

efbc9ff

…eness

Merge pull request #85 from Roave/internal-class-reflections-runtime-…

12c091a

…stubbing Internal class reflections runtime stubbing

Ocramius changed the title ~~[WIP] Internal class reflections~~ Internal class reflections Jul 22, 2015

Ocramius added a commit that referenced this pull request Jul 22, 2015

Merge pull request #80 from Roave/internal-class-reflections

a5bcb25

Internal class reflections

Ocramius merged commit a5bcb25 into master Jul 22, 2015

Ocramius deleted the internal-class-reflections branch July 22, 2015 00:58

This was referenced Jul 26, 2015

Updated documentation to reflect recent changes #86

Merged

Create ReflectionFunctions/ReflectionClasses from internal definitions #38

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal class reflections #80

Internal class reflections #80

asgrim commented Jul 20, 2015

Ocramius Jul 21, 2015

asgrim Jul 21, 2015

Internal class reflections #80

Internal class reflections #80

Conversation

asgrim commented Jul 20, 2015

Todo

Ocramius Jul 21, 2015

Choose a reason for hiding this comment

asgrim Jul 21, 2015

Choose a reason for hiding this comment