Ensure graphviz support is enabled, automated dependency upgrades, restructured tests around docker image #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: all tests already pass this way - the problem is that our CI tests install all required dependencies independently of our `Dockerfile` (to be adjusted)
…build targets Also added some multi-stage build improvements to: * have a common `composer-base-image` alias that we can upgrade from * install dependencies without filling `composer` cache * avoid having dev dependencies in the production image * better parallel execution time
….json` to prevent shifting dependencies
…n the context of the provided `Dockerfile` (built image)
… as auto-merging thereof
…xport layers Should fix this: ``` time="2022-03-16T13:03:07Z" level=warning msg="No output specified for docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load" ``` Ref: https://github.com/Roave/DocbookTool/runs/5570347931?check_suite_focus=true#step:4:225
This fixes the invalid shebang parsing when loading `vendor/bin/$tool` scripts in CI.
Fixes following:
```
Run docker run --rm --entrypoint=bash test-image vendor/bin/psalm
docker run --rm --entrypoint=bash test-image vendor/bin/psalm
shell: /usr/bin/bash -e {0}
vendor/bin/psalm: line 2: ?php: No such file or directory
vendor/bin/psalm: line 4: /app: Is a directory
vendor/bin/psalm: line 5: bin: command not found
vendor/bin/psalm: line 6: bin: command not found
vendor/bin/psalm: line 7: syntax error near unexpected token `('
vendor/bin/psalm: line 7: ` * This file includes the referenced bin path (../vimeo/psalm/psalm)'
```
Ref: https://github.com/Roave/DocbookTool/runs/5570444286?check_suite_focus=true#step:5:1
Ocramius
commented
Mar 16, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Dockerfilecomposer,dockerandnpmdependency upgradesFixes #19