Basic signer and checker #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 16, 2016 13:44
- Introduce checker interface
- A signed file needs to have a commented line `Roave/Signature: SIGNER-KEY` - The line with the signer key will be removed before check against the signature - The line removal occurs only on run time, nothing is modified or saved, just read - DId leave TODO's in there just to see if we're doing in a good way
…amed constructor method to create the exception instead of change the internal property `$message` on the exception class
added 19 commits
November 25, 2016 11:27
…atureException class
asgrim
approved these changes
Dec 23, 2016
There was a problem hiding this comment.
Good for a first iteration IMO, approving this! Nice one, @malukenho 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.