Allow PHP ^8.0, add Github Actions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'm not the owner of this repo) Hi, you have a much higher chance of merging a PR if you create two separate ones, each for separate concern this PR includes. |
|
Hi, thank you for the suggestion. I am aware of that. The reason why it is in single PR is the response time of the Travis CI (sometimes takes hours). The scope of |
This was referenced Apr 5, 2021
|
See Github Actions executed in the fork scope: trejjam/roave-no-floaters#1 |
joshuaslaney
approved these changes
Apr 21, 2021
joshuaslaney
approved these changes
Apr 21, 2021
joshuaslaney
approved these changes
Apr 24, 2021
|
@joshuaslaney, please stop. This is not how things works... |
Ocramius
approved these changes
May 7, 2021
|
|
||
| strategy: | ||
| matrix: | ||
| php-version: ["7.4"] |
|
|
||
| strategy: | ||
| matrix: | ||
| php-version: ["7.4"] |
| .PHONY: install qa cs phpstan tests mutation-tests | ||
|
|
||
| install: | ||
| composer update |
There was a problem hiding this comment.
It makes sense. I totally overlooked it. Thank you for the review!
| @@ -5,16 +5,16 @@ | |||
| "MIT" | |||
| ], | |||
| "require": { | |||
| "php": "^7.2", | |||
| "php": "^7.4 | ^8.0", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds support for PHP 8.0 in composer.json. And it also replaces Travis with Github Actions (based on Contributte Actions).