Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure MappingDriverChain is still instantiated without a default driver if not configured #18

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Make sure MappingDriverChain is still instantiated without a default driver if not configured #18

merged 1 commit into from
Feb 10, 2020

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Feb 10, 2020

Fixes #17

@asgrim asgrim added the bug Something isn't working label Feb 10, 2020
@asgrim asgrim requested a review from Ocramius February 10, 2020 13:15
@Ocramius Ocramius changed the base branch from master to 2.1.x February 10, 2020 14:22
@Ocramius Ocramius self-assigned this Feb 10, 2020
@Ocramius Ocramius added this to the 2.1.1 milestone Feb 10, 2020
Ocramius
Ocramius approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asgrim note: I've moved the target to 2.1.x to tag a stable release from there.

@Ocramius Ocramius changed the title Make sure MappingDriverChain is still instantiated without a default driver if not configured Make sure MappingDriverChain is still instantiated without a default driver if not configured Feb 10, 2020
@Ocramius Ocramius merged commit b7bc356 into 2.1.x Feb 10, 2020
@Ocramius Ocramius deleted the bugfix/check-for-array-key branch February 10, 2020 14:23
@Ocramius Ocramius mentioned this pull request Feb 10, 2020
Closed
@asgrim asgrim mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

Undefined index: default_driver
2 participants
@asgrim @Ocramius