Declare hard dependency on doctrine/cache #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has a hard dependency on doctrine/cache v1 via `CacheFactory`. But that dependency was not declared as such, yet it was fullfilled by coincidence via a transient dependency. And the relatively recent doctrine/cache v2 introduced **a lot** of breaking changes that break not only this package tests, but also virtually all of dependents of this package. Fixes Roave#46
PowerKiKi
force-pushed
the
cache-dependency
branch
from
2cd6980
to
f6bc561
Compare
|
Thanks @PowerKiKi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package has a hard dependency on doctrine/cache v1 via
CacheFactory.But that dependency was not declared as such, yet it was fullfilled by coincidence
via a transient dependency. And the relatively recent doctrine/cache v2
introduced a lot of breaking changes that break not only this package
tests, but also virtually all of dependents of this package.
Fixes #46